fix: add Jackson annotations and defensive copying to SearchResponse#99
Open
adityamparikh wants to merge 1 commit into
Open
fix: add Jackson annotations and defensive copying to SearchResponse#99adityamparikh wants to merge 1 commit into
adityamparikh wants to merge 1 commit into
Conversation
Add @JsonInclude(NON_NULL) and @JsonIgnoreProperties(ignoreUnknown = true) annotations for consistency with collection DTOs in Dtos.java. Add compact constructor with defensive copying using List.copyOf() and Map.copyOf() for the mutable documents and facets fields, defaulting to empty collections when null. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
adityamparikh
force-pushed
the
fix/search-response-annotations
branch
from
2262c39 to
54fbfad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@JsonInclude(NON_NULL)and@JsonIgnoreProperties(ignoreUnknown = true)toSearchResponsefor consistency with collection DTOs inDtos.javaList.copyOf()andMap.copyOf()for mutabledocumentsandfacetsfields, defaulting to empty collections when nullTest plan
./gradlew buildpasses./gradlew nativeTest -Pnativepasses (119/119 tests)🤖 Generated with Claude Code